Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to the same comment for offline test analytics #522

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

michelletran-codecov
Copy link
Contributor

@michelletran-codecov michelletran-codecov commented Oct 2, 2024

Changes:

  • Update existing GitHub Actions message (matches on tag).
  • Remove emitting message to GitHub Actions Summary (don't want this extra feature for parity with the Online Test Analytics)

Does not update the message yet (still using previously formatted message).

@michelletran-codecov michelletran-codecov force-pushed the 2586_update_test_results_message branch 9 times, most recently from b438605 to e4c4dd1 Compare October 2, 2024 20:55
@codecov codecov deleted a comment from github-actions bot Oct 3, 2024
@codecov codecov deleted a comment from github-actions bot Oct 3, 2024
@michelletran-codecov michelletran-codecov force-pushed the 2586_update_test_results_message branch 2 times, most recently from 18d73f7 to ab608b0 Compare October 3, 2024 15:47
Copy link

codecov bot commented Oct 3, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3495 5 3490 0
View the top 3 failed tests by shortest run time
api.temp.calculator.test_calculator test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@codecov codecov deleted a comment from github-actions bot Oct 3, 2024
@codecov codecov deleted a comment from github-actions bot Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@michelletran-codecov michelletran-codecov force-pushed the 2586_update_test_results_message branch 12 times, most recently from ff5808e to 93d1366 Compare October 4, 2024 14:57
@michelletran-codecov michelletran-codecov force-pushed the 2586_update_test_results_message branch 4 times, most recently from 418a59e to 46a27ce Compare October 4, 2024 15:44
@michelletran-codecov michelletran-codecov marked this pull request as ready for review October 4, 2024 15:46
@michelletran-codecov michelletran-codecov requested a review from a team October 4, 2024 15:46
The ref can also reference a branch when it's merged. Ensure that we're
only running this for a PR.
To have feature parity with the existing Test Analytics, we don't
actually want to publish to the GitHub Actions Summary.
@michelletran-codecov michelletran-codecov merged commit 5fb1837 into main Oct 10, 2024
18 checks passed
@michelletran-codecov michelletran-codecov deleted the 2586_update_test_results_message branch October 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants