Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle analysis: Temp mock for routes field of Assets #995

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

JerrySentry
Copy link
Contributor

Set up the GQL field for returning routes of a given asset. Currently just hardcode some return value so that FE can start using it for testing. Coming up next PR will be calculating the real values

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry requested a review from a team as a code owner November 20, 2024 21:22
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (dc8d67a) to head (cfc998c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         828      828           
  Lines       19183    19186    +3     
=======================================
+ Hits        18424    18427    +3     
  Misses        759      759           
Flag Coverage Δ
unit 92.32% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2024
@JerrySentry JerrySentry added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit c040388 Nov 22, 2024
19 checks passed
@JerrySentry JerrySentry deleted the nov_20_ba_pathing_mock branch November 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants