Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide an opt to skip s3 upload #140

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: provide an opt to skip s3 upload #140

wants to merge 5 commits into from

Conversation

kobenguyent
Copy link
Collaborator

resolves #139

@kobenguyent kobenguyent requested a review from puneet0191 June 4, 2024 09:20
@mbrodala
Copy link

This skips S3 upload completely which does not fix #139.

You can instead not configure S3, then there already will be no upload.

My issue was about skipping upload of diff and output but keep the upload for base.

@kobenguyent
Copy link
Collaborator Author

oh I think I misunderstood here, so thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneet0191 puneet0191 Awaiting requested review from puneet0191

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionally skip "output" & "diff" upload to S3
2 participants
@kobenguyent @mbrodala