Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move tryTo, retryTo to effects #4743

Merged
merged 6 commits into from
Jan 15, 2025
Merged

move tryTo, retryTo to effects #4743

merged 6 commits into from
Jan 15, 2025
+300 −482

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Jan 13, 2025 •
edited
Loading

Motivation/Description of the PR

  • move tryTo, retryTo to effects
  • push errors to notes on fail for hopeThat

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent requested a review from DavertMik January 13, 2025 13:22
DavertMik
DavertMik requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopeThat should either be removed or re-implemented to not be the same as tryTo

hopeThat can store failures inside test.notes (additional listener needed) and raise an error if error has appeared

lib/effects.js Outdated Show resolved Hide resolved
lib/effects.js Outdated Show resolved Hide resolved
lib/effects.js Show resolved Hide resolved
@kobenguyent kobenguyent requested a review from DavertMik January 14, 2025 12:51
DavertMik
DavertMik approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change

lib/effects.js Outdated Show resolved Hide resolved
@kobenguyent kobenguyent merged commit 117c6c1 into 3.x Jan 15, 2025
12 checks passed
@kobenguyent kobenguyent deleted the move-more-to-effects branch January 15, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobenguyent @DavertMik