Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error thrown when element text is an empty string #4702

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent requested a review from DavertMik January 2, 2025 15:50
@DavertMik
Copy link
Contributor

@kobenguyent let's run prettier on the whole codebase to fix all styles

@kobenguyent kobenguyent requested a review from DavertMik January 3, 2025 05:18
@kobenguyent
Copy link
Collaborator Author

@kobenguyent let's run prettier on the whole codebase to fix all styles

thanks! Applied the prettier and fixed conflicts.

@kobenguyent kobenguyent merged commit 0a82941 into 3.x Jan 3, 2025
10 checks passed
@kobenguyent kobenguyent deleted the fix-grabTextFrom-empty-text branch January 3, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants