Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint from v8 to v9 #4592

Merged

Conversation

thomashohn
Copy link
Contributor

Motivation/Description of the PR

  • Dump eslint from v8 to v9
  • Resolves 4590

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@thomashohn
Copy link
Contributor Author

@kobenguyent - not sure why the typing tests are failing because of the eslint upgrade ? Seems unrelated or?

@kobenguyent
Copy link
Collaborator

@kobenguyent - not sure why the typing tests are failing because of the eslint upgrade ? Seems unrelated or?

missing args?

  typings/promiseBasedTypes.d.ts:367:8
  ✖  367:8  Property runInWeb in type AppiumTs is not assignable to the same property in base type WebDriverTs.
  Type (fn: any) => Promise<any> is not assignable to type () => Promise<any>.
    Target signature provides too few arguments. Expected 1 or more, but got 0.  

  typings/types.d.ts:367:8
  ✖  367:8  Property runInWeb in type Appium is not assignable to the same property in base type WebDriver.
  Type (fn: any) => void is not assignable to type () => void.
    Target signature provides too few arguments. Expected 1 or more, but got 0.                      

  2 errors

@thomashohn
Copy link
Contributor Author

But from what are the files generated? Seem to be my problem

@kobenguyent
Copy link
Collaborator

sounds like the issue is here

async runInWeb(fn) {

the function provides param but the typing is not.

@thomashohn
Copy link
Contributor Author

@kobenguyent - seems to be over my skills to solve that issue ..

@kobenguyent
Copy link
Collaborator

@kobenguyent - seems to be over my skills to solve that issue ..

Let me take a look if I could fix it.

@kobenguyent
Copy link
Collaborator

looks good for now @thomashohn

@kobenguyent kobenguyent merged commit 9322fae into codeceptjs:3.x Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants