-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated performSwipe with w3c protocol #4154
fix: updated performSwipe with w3c protocol #4154
Conversation
* release 3.5.12
trim text content value
Bumps [testcafe](https://github.com/DevExpress/testcafe) from 3.3.0 to 3.5.0. - [Release notes](https://github.com/DevExpress/testcafe/releases) - [Changelog](https://github.com/DevExpress/testcafe/blob/master/CHANGELOG.md) - [Commits](DevExpress/testcafe@v3.3.0...v3.5.0) --- updated-dependencies: - dependency-name: testcafe dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lib/helper/Appium.js
Outdated
} | ||
/* eslint-enable */ | ||
|
||
/** | ||
* Perform a swipe on the screen. | ||
* | ||
* ```js | ||
* I.performSwipe({ x: 300, y: 100 }, { x: 200, y: 100 }); | ||
* I.performSwipe(elementId, { x: 300, y: 100 }, { x: 200, y: 100 }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to performSwipe without passing the elementId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id: - is mandatory attribute of the w3c call. But can be used some random string inside the method instead of elementId parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'll be great if we could implement like that. Cause we actually perform swipe without knowing any element id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed elementId but after merge after sync with main repo I got some extra files changes. Not sure why
…tocol' into performeSwipe-updated-to-w3c-protocol
…tocol' into performeSwipe-updated-to-w3c-protocol
Is there any blocker from merging this PR? |
This reverts commit 3b34ae6.
unfortunately, it broke our appium tests. |
Which tests were broken. And where can I find the report? |
Please check them here:
|
Motivation/Description of the PR
Applicable helpers:
Type of change
Checklist:
npm run lint
)