fix: seeAttributesOnElements check condition

[kobenguyent]

Motivation/Description of the PR

• fix: seeAttributesOnElements check condition

    --- STARTED "before each" hook: Before for "this should work, but doesnt @jaja" ---
 › Cannot save user session with empty cookies from auto login's fetch method
    I am on page "https://google.com"
    › [Browser:Info] Autofocus processing was blocked because a document already has a focused element.
    --- ENDED "before each" hook: Before for "this should work, but doesnt @jaja" ---
    I am on page "https://github.com/codeceptjs/CodeceptJS/"
    I see attributes on elements {"css":"a[href=\"/team\"]"}, {"href":"/team"}
https://github.com/team /team
  ✔ OK in 1051ms

• Resolves (playwright) href inconsistent #3170

Applicable helpers:

• Playwright
• Puppeteer

Type of change

• 🐛 Bug fix

Checklist:

• Tests have been added
• Documentation has been added (Run npm run docs)
• Lint checking (Run npm run lint)
• Local tests are passed (Run npm test)

[basalingayyakaramadi]

@kobenguyent With this update we are seeing issue when we use seeAttributesOnElements, existing tests are failing with below error,

_actual.includes is not a function
      at /tests/node_modules/codeceptjs/lib/helper/Puppeteer.js:1825:22
      at Array.filter (<anonymous>)
      at Puppeteer.seeAttributesOnElements (node_modules/codeceptjs/lib/helper/Puppeteer.js:1821:23)
  

any solution ?

[kobenguyent]

@basalingayyakaramadi please give us a sample code to reproduce your issue

[basalingayyakaramadi]

Eg:

titleInput= 'input[formcontrolname="title"]'
 I.seeAttributesOnElements(titleInput, { disabled: true });

i will setup actual code and let you know.

[hixus]

Eg:

titleInput= 'input[formcontrolname="title"]'
 I.seeAttributesOnElements(titleInput, { disabled: true });

i will setup actual code and let you know.

You are correct, reason being Playwright returns non-value attributes as booleans and this mr started using .includes which is string method.

Change also makes attribute selectors essentially wildcards as any substring match will pass. Which is something likely not wanted. Therefore href should be handled separately from others.