Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystem: JSDoc: Fixed a typo in writeToFile(), added a unit test #3897

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

mirao
Copy link
Contributor

@mirao mirao commented Sep 28, 2023

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@mirao mirao changed the title FileSystem: JSDoc: Fixed a typo in writeToFile() FileSystem: JSDoc: Fixed a typo in writeToFile(), added a unit test Sep 28, 2023
@mirao
Copy link
Contributor Author

mirao commented Sep 28, 2023

I don't know why https://github.com/codeceptjs/CodeceptJS/actions/runs/6342453311/job/17228234303?pr=3897 failed. It passed in my environment (npm test).
The unit test I added in this PR passed.

@mirao
Copy link
Contributor Author

mirao commented Sep 29, 2023

OK, I can see that a re-run https://github.com/codeceptjs/CodeceptJS/actions/runs/6342453311 run by @kobenguyent passed.
BTW I didn't find a way how to re-run failed test in GitHub UI. Any idea? Or just I'm stupid 😄 .

@kobenguyent
Copy link
Collaborator

I'm not sure but I think you need to have the permission granted by the project owner.

@kobenguyent kobenguyent added typescript Changes for typings or typescript compatibility documentation and removed typescript Changes for typings or typescript compatibility labels Oct 4, 2023
@kobenguyent kobenguyent merged commit e0ac568 into codeceptjs:3.x Oct 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants