fix: respect retries from retryfailedstep plugin in helpers (#4028)

codeceptjs · Nov 29, 2023 · c286f42 · c286f42
1 parent 159350b
commit c286f42
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/lib/helper/Playwright.js b/lib/helper/Playwright.js
@@ -474,7 +474,7 @@ class Playwright extends Helper {
   async _before(test) {
     this.currentRunningTest = test;
     recorder.retry({
-      retries: 5,
+      retries: process.env.FAILED_STEP_RETIRES || 3,
       when: err => {
         if (!err || typeof (err.message) !== 'string') {
           return false;

diff --git a/lib/helper/Puppeteer.js b/lib/helper/Puppeteer.js
@@ -297,7 +297,7 @@ class Puppeteer extends Helper {
     this.sessionPages = {};
     this.currentRunningTest = test;
     recorder.retry({
-      retries: 3,
+      retries: process.env.FAILED_STEP_RETIRES || 3,
       when: err => {
         if (!err || typeof (err.message) !== 'string') {
           return false;

diff --git a/lib/plugin/retryFailedStep.js b/lib/plugin/retryFailedStep.js
@@ -117,6 +117,8 @@ module.exports = (config) => {
 
   event.dispatcher.on(event.test.before, (test) => {
     if (test && test.disableRetryFailedStep) return; // disable retry when a test is not active
+    // this env var is used to set the retries inside _before() block of helpers
+    process.env.FAILED_STEP_RETIRES = config.retries;
     recorder.retry(config);
   });
 };
diff --git a/test/unit/plugin/retryFailedStep_test.js b/test/unit/plugin/retryFailedStep_test.js
@@ -36,6 +36,7 @@ describe('retryFailedStep', () => {
     }, undefined, undefined, true);
     return recorder.promise();
   });
+
   it('should not retry within', async () => {
     retryFailedStep({ retries: 1, minTimeout: 1 });
     event.dispatcher.emit(event.test.before, {});
@@ -54,6 +55,7 @@ describe('retryFailedStep', () => {
       await recorder.catchWithoutStop((err) => err);
     }
 
+    expect(process.env.FAILED_STEP_RETIRES).to.equal('1');
     // expects to retry only once
     counter.should.equal(2);
   });