fix(playwright): Different behavior of see* and waitFor* when used in…

… within (#4557) * fix(playwright): no context is used for wait* functions * fix(playwright): no context is used for wait* functions * fix(ppt): no context is used for wait* functions * fix(ppt): no context is used for wait* functions * fix(ppt): no context is used for wait* functions * fix(playwright): no context is used for wait* functions * fix(ppt): no context is used for wait* functions
codeceptjs · Dec 10, 2024 · 6e259e9 · 6e259e9
1 parent 344aacf
commit 6e259e9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/lib/helper/Playwright.js b/lib/helper/Playwright.js
@@ -1283,7 +1283,7 @@ class Playwright extends Helper {
    * ```
    */
   async _locate(locator) {
-    const context = (await this.context) || (await this._getContext())
+    const context = await this._getContext()
 
     if (this.frame) return findElements(this.frame, locator)
 
@@ -1299,7 +1299,7 @@ class Playwright extends Helper {
    * ```
    */
   async _locateElement(locator) {
-    const context = (await this.context) || (await this._getContext())
+    const context = await this._getContext()
     return findElement(context, locator)
   }
 
@@ -2736,7 +2736,7 @@ class Playwright extends Helper {
   }
 
   async _getContext() {
-    if (this.context && this.context.constructor.name === 'FrameLocator') {
+    if ((this.context && this.context.constructor.name === 'FrameLocator') || this.context) {
       return this.context
     }
     return this.page

diff --git a/test/helper/Playwright_test.js b/test/helper/Playwright_test.js
@@ -37,7 +37,7 @@ describe('Playwright', function () {
 
     I = new Playwright({
       url: siteUrl,
-      windowSize: '500x700',
+      // windowSize: '500x700',
       browser: process.env.BROWSER || 'chromium',
       show: false,
       waitForTimeout: 5000,
@@ -205,6 +205,17 @@ describe('Playwright', function () {
 
       await I.waitToHide('h9')
     })
+
+    it('should wait for invisible combined with dontseeElement', async () => {
+      await I.amOnPage('https://codecept.io/')
+      await I.waitForVisible('.frameworks')
+      await I.waitForVisible('[alt="React"]')
+      await I.waitForVisible('.mountains')
+      await I._withinBegin('.mountains', async () => {
+        await I.dontSeeElement('[alt="React"]')
+        await I.waitForInvisible('[alt="React"]', 2)
+      })
+    })
   })
 
   describe('#waitToHide', () => {

diff --git a/test/helper/Puppeteer_test.js b/test/helper/Puppeteer_test.js
@@ -32,7 +32,7 @@ describe('Puppeteer - BasicAuth', function () {
 
     I = new Puppeteer({
       url: siteUrl,
-      windowSize: '500x700',
+      // windowSize: '500x700',
       show: false,
       waitForTimeout: 5000,
       waitForAction: 500,