feat(#3101): implement UI for logging groups #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteKoe
force-pushed
the
feat/3101-logging-groups
branch
from
fd8bf48
to
663edde
Compare
erikpetzold
reviewed
Oct 7, 2024
spring-boot-admin-server-ui/src/main/frontend/services/startup-actuator.ts
Outdated
Show resolved
Hide resolved
erikpetzold
approved these changes
Oct 9, 2024
erikpetzold
reviewed
Oct 9, 2024
| return this.value.some((l) => { | ||
| return l.effectiveLevel === level || l.members | ||
| ? this.hasConfiguredLevel(level) | ||
| : false; |
There was a problem hiding this comment.
as already discussed in the chat, I still think that this could be written in a easier-to-understand way
…eat/3101-logging-groups * origin/feat/3101-logging-groups:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3101
logging_group.mov