Enable internal classes #43
Conversation
|
I like it, can you do a few things:
Thanks! |
|
Sure thing |
|
So, working on the broader topic, what would we want to have?
Wrt. nested members:
What are your thoughts on that? |
|
Sorry, I was occupied :( |
anotherthomas
force-pushed
the
internal_classes
branch
from
b12d15b
to
68f191c
Compare
anotherthomas
force-pushed
the
internal_classes
branch
from
68f191c
to
54eac72
Compare
|
Tests split, version bumped :) |
| @@ -25,7 +25,7 @@ | |||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | |||
| <EnableNETAnalyzers>True</EnableNETAnalyzers> | |||
| <AnalysisLevel>latest-Recommended</AnalysisLevel> | |||
| <Version>2.3.0</Version> | |||
| <Version>3.0.0</Version> | |||
There was a problem hiding this comment.
Yes, definitely needed.
I would suggest also adding examples, changelog and your name to Readme.md - especially calling out that you fixed a bug where classes without access modifier where wrongly set to public instead of internal.
|
|
||
| public partial class AccessibilityTests | ||
| { | ||
| private static string GenerateCode(string code) |
There was a problem hiding this comment.
Hm, this dublicates code in the original tests.
Maybe use the same partial class tests I've used like in AutomaticInterface/Tests/GeneratorsTests.MethodParameters.cs?
| } | ||
|
|
||
| [Fact] | ||
| public void AddsPublicMethodToInterface() |
There was a problem hiding this comment.
What does this test test?
Seems to me already tested by existing tests?
| } | ||
|
|
||
| [Fact] | ||
| public void WorksWithInternal() |
There was a problem hiding this comment.
I don't see internal here?
| } | ||
|
|
||
| [Fact] | ||
| public void WorksWithDefaultAccessModifier() |
There was a problem hiding this comment.
Looks like the above test?
|
Sorry, had several things on my plate those last few months. Still interested? |
|
Yes! You need probably to rebase |
To facilitate API design for assemblies, [GenerateAutomaticInterface] should take
internalvisibility into account. The interface can be useful for dependency injection without necessarily being part of the public API of an assembly.