Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prep multimlframeworks #95

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Conversation

dstalzjohn
Copy link
Collaborator

@dstalzjohn dstalzjohn commented Dec 8, 2023

📥 Pull Request Description

This pullrequest has some breaking changes. Thus, please control it thoroughly. It should help to easier integrate multiple frameworks to niceml like pytorch or hugging face transformers.

There are two things implemented:

  • Separation of datasets
  • The interface of the learner class is generalized

👀 Affected Areas

Code and documentation.

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@dstalzjohn dstalzjohn requested review from aiakide and ankeko December 8, 2023 13:43
@dstalzjohn dstalzjohn self-assigned this Dec 8, 2023
@aiakide aiakide merged commit 2242721 into develop Dec 18, 2023
6 checks passed
@aiakide aiakide deleted the feature/prep_multimlframeworks branch December 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants