Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate mkdocs graphs with multiple dependencies #86

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

ankeko
Copy link
Collaborator

@ankeko ankeko commented Oct 18, 2023

📥 Pull Request Description

Implemented option to generate pipeline graphs of dagster jobs with multiple op dependencies.

👀 Affected Areas

Documentation

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@ankeko ankeko added 🪲 bug Related to bugs or unexpected behavior 📚 documentation Related to documentation or the need for additional documentation 🔧 enhancement Requests for improvements or enhancements to existing features labels Oct 18, 2023
@ankeko ankeko requested a review from aiakide October 18, 2023 09:33
niceml/mkdocs/mdgraph.py Outdated Show resolved Hide resolved
niceml/mkdocs/mdjob.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@aiakide aiakide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 🎉

@aiakide aiakide merged commit 61488b2 into develop Nov 8, 2023
6 checks passed
@aiakide aiakide deleted the fix/dagster_docs branch November 8, 2023 12:55
@aiakide aiakide mentioned this pull request Nov 8, 2023
7 tasks
aiakide pushed a commit that referenced this pull request Nov 8, 2023
## 📥 Pull Request Description

Implemented option to generate pipeline graphs of dagster jobs with
multiple op dependencies.

## 👀 Affected Areas

Documentation

## 📝 Checklist

Please make sure you've completed the following tasks before submitting
this pull request:

- [x] Pre-commit hooks were executed
- [x] Changes have been reviewed by at least one other developer
- [ ] Tests have been added or updated to cover the changes (only
necessary if the changes affect the executable code)
- [x] All tests ran successfully
- [x] All merge conflicts are resolved
- [ ] Documentation has been updated to reflect the changes
- [ ] Any necessary migrations have been run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Related to bugs or unexpected behavior 📚 documentation Related to documentation or the need for additional documentation 🔧 enhancement Requests for improvements or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants