Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add write chart to exp context #135

Merged
merged 5 commits into from
Aug 12, 2024
Merged

feat: add write chart to exp context #135

merged 5 commits into from
Aug 12, 2024

Conversation

ankeko
Copy link
Collaborator

@ankeko ankeko commented Aug 9, 2024

📥 Pull Request Description

Added write_chart function to experiment context to save html images and others.

👀 Affected Areas

Experiment Context

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@ankeko ankeko requested a review from aiakide August 9, 2024 12:53
@ankeko ankeko added ✨ feature Requests or discussions about new features 🔧 enhancement Requests for improvements or enhancements to existing features labels Aug 9, 2024
aiakide
aiakide requested changes Aug 9, 2024
View reviewed changes
niceml/experiments/experimentcontext.py Show resolved Hide resolved
niceml/experiments/experimentcontext.py Outdated Show resolved Hide resolved
niceml/utilities/ioutils.py Outdated Show resolved Hide resolved
tests/unit/niceml/experiments/test_experimentcontext.py Show resolved Hide resolved
aiakide
aiakide approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@aiakide aiakide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work and your efforts

@ankeko ankeko enabled auto-merge (rebase) August 12, 2024 09:45
@ankeko ankeko merged commit 46f9f53 into develop Aug 12, 2024
6 checks passed
@ankeko ankeko deleted the feature/add_write_chart_to_exp_context branch August 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiakide aiakide aiakide approved these changes

Assignees
No one assigned
Labels
🔧 enhancement Requests for improvements or enhancements to existing features ✨ feature Requests or discussions about new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankeko @aiakide