Add url connection and read timeouts

[pavlogs]

Resolution for Issue #8

[asolntsev]

@pavlogs Don't we want to make this timeout configurable? Maybe 10 seconds is not enough in some projects?..

[pavlogs]

@pavlogs Don't we want to make this timeout configurable? Maybe 10 seconds is not enough in some projects?..

@asolntsev Good point. IMHO a separate configuration class should be introduced to have greater flexibility and handle such cases.
I can open feature request for later. WDYT?

[asolntsev]

Maybe just add another parameter to the related methods?

Any experience with configuration class shows that such a class can quickly grow into an uncontrollable monster with tons of settings. I am a bit afraid of it.

[pavlogs]

grow into an uncontrollable monster

Would agree about this statement 🙂

Maybe just add another parameter to the related methods?

That method is private so it won't affect publicly available api. As an option and to be consistent with a current approach, another constructor could be introduced (see example commit). However it will increase complexity of existing constructors (eg. this two).
Seems like usage of builder suites this class. WDYT? I can open another PR if you think such way of configuration is good enough.

[asolntsev]

This private method is used in exactly two public constructors:

• new PDF(URL url), and
• new PDF(URL url, int startPage, int endPage).

I agree, adding 2 more methods would be too much.
Probably yes, the builder is a good idea.

[pavlogs]

Hello, @asolntsev 👋
Finally got a chance to dig into the timeout setup issue. After looking into it, I think going for a builder or factory method might introduce some breaking changes, and I'd rather avoid that. Plus, you've got another project, xls-test, that would need the same changes to keep consistency.
There is another way how it can be approached - by making readBytes publicly available
Please take a look and if you are ok with this solution I will open a PR

[asolntsev]

@pavlogs Yes, we can do a similar change in xls-test, why not?

Sorry, I didn't undestand how making readBytes public solves our problem.

[pavlogs]

Excuse me for any possible confusion. The general idea was to make timeout configurable. I thought it would be clear from the added tests how it could be achieved. From the framework point of view only readBytes with URLConnection in the signature was added. Constructor with byte[] is available.
So, to make long story short. Adding public method is not mandatory - url connection timeout could be configured without changing anything.