Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide sponsor form link if it's undefined, fixes #10 #13

Merged
merged 4 commits into from
Oct 25, 2021
Merged

hide sponsor form link if it's undefined, fixes #10 #13

merged 4 commits into from
Oct 25, 2021

Conversation

phette23
Copy link
Member

also edit a few if conditions to use != nil, ref #8

testing:

  • open up /prospectus/ and the final paragraph under Impact of Support should show the sponsorship email but not the form link
  • extra credit: comment out the sponsorship email & the email there as well as the yellow "contact" sidebar should both disappear

@dzoladz
Copy link
Member

dzoladz commented Oct 24, 2021

Tested changes made by @phette23. Those modifications function as described.

While review those updates, I noticed a context button that was visibly hidden because it lacked the context button stylings. I've added a few directives to make the button appear on the interface and folded in the logic to hook it to the existence of `{{ site.data.conf.sponsor-btn-link }}'

Screen Shot 2021-10-24 at 8 40 40 AM

@phette23
Copy link
Member Author

Good catch @dzoladz! I can confirm your changes work (button doesn't display without btn-link value, if you add it the button displays with appropriate styles). The online conference sentence is also gone.

Looks like you can't review your own PRs but I sign off. I won't merge in case we want a third party to review first.

@dzoladz
Copy link
Member

dzoladz commented Oct 25, 2021

As this one is a low impact change, and we've already reviewed each other's work, I don't think it's critical to have a third-party review.

I'll merge this one into main before creating a PR to open proposals.

@dzoladz dzoladz merged commit 01064c1 into main Oct 25, 2021
@dzoladz dzoladz deleted the iss10 branch October 25, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants