generated from code4lib/2021.code4lib.org
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When Testing for the Existence of Config Data, Use != nil #8
Comments
phette23
added a commit
that referenced
this issue
Oct 22, 2021
also edit a few if conditions to use `!= nil`, ref #8
Could the preferred way to handle empty variables in the config and templates also be added to the style guide? This would be helpful to ensure we remain consistent going forward. |
@ranti Would you be able to find an appropriate place in the above referenced style guide to add this info? |
This was referenced Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per @phette23
Here's a comment that discusses the boolean logic of these values
We'll need to globally find and replace these tests, carefully and perhaps selectively at first. There are likely associated updates that will need to be made to configuration and data files. See PR #7 for and example.
The text was updated successfully, but these errors were encountered: