Feat job seeker UI #555
Feat job seeker UI #555
Conversation
|
@VineeTagarwaL-code let me know if it requires more changes or not |
|
Cool pr, had a good chat in discord dms ... waiting for the small addition asked then will review the whole code |
|
this will be little time taking and constant request response will be needed, so please bear with me for the time being Thanks again ! |
|
@VineeTagarwaL-code |
next.config.js
Outdated
| } | ||
| }, | ||
| { | ||
| protocol: 'https', |
| @@ -120,6 +147,7 @@ model Project { | |||
| stack ProjectStack @default(OTHERS) | |||
| userId String | |||
| user User @relation(fields: [userId], references: [id], onDelete: Cascade) | |||
| isFeature Boolean @default(false) | |||
There was a problem hiding this comment.
what is "isFeature"
There was a problem hiding this comment.
there was a "Feature this project" in the figma, so i added this field in the schema. If the isFeature is set to true then the project will show up other it will hide under show more button
prisma/seed.ts
Outdated
| { id: '1', name: 'Jack', email: '[email protected]' }, | ||
| { id: '2', name: 'Admin', email: '[email protected]', role: Role.ADMIN, onBoard: true }, | ||
| { id: '3', name: 'Hr', email: '[email protected]', role: Role.HR }, | ||
| { id: '1', name: 'Jack', email: '[email protected]', username: 'jackcoder' }, |
There was a problem hiding this comment.
add role: Role.USER
src/actions/auth.actions.ts
Outdated
| @@ -42,7 +42,8 @@ export const signUp = withServerActionAsyncCatcher< | |||
| await prisma.$transaction( | |||
| async (txn) => { | |||
| const user = await txn.user.create({ | |||
| data: { ...data, password: hashedPassword }, | |||
| // todo username | |||
| data: { ...data, password: hashedPassword, username: 'asdif' }, | |||
There was a problem hiding this comment.
username doesnt look good ig
There was a problem hiding this comment.
username was present in figma. changing schema leads to require username whenever user is being created. we can remove username from schema or need to add username input in signup form.
| @@ -0,0 +1,86 @@ | |||
| import { useState } from 'react'; | |||
| import { deleteExperience } from '@/actions/user.profile.actions'; | |||
There was a problem hiding this comment.
this is experience delete dialog box and the name of the file is accountdeletedialog
misleading ig
There was a problem hiding this comment.
sorry this file is mistakenly committed
this component is not used anywhere.
There was a problem hiding this comment.
you have a file called expdeleteDialog in which you call deleteExp()
and same you are doing here, are you sure this is correct ?
There was a problem hiding this comment.
sorry this file is mistakenly committed
this component is not used anywhere.
There was a problem hiding this comment.
the naming of this file is not proper it should aboutMe only
There was a problem hiding this comment.
okay changing the name of the file
|
in the profile edit section make the links as optional, the users wont be able to submit the form if they didnt filled every field, |
|
@VineeTagarwaL-code |
|
@VineeTagarwaL-code gggggg.mp4 |
|
Test it our for every edge case you can think of and write it out here in this form
etc |
|
@VineeTagarwaL-code |
|
no results yet ? |
|
@VineeTagarwaL-code |
|
yeah yeah why not |
|
build failed |
|
@VineeTagarwaL-code |
|
give a video ref demonstrating the whole flow |
|
and fix the conflicts too |
|
https://drive.google.com/file/d/1lX7gi_881D86Yk3wl52jBepf2ttHJIWG/view?usp=sharing here is the video images are not showing in the video because my bunny cdn free trial is expired. |
|
we can improve the code quality by getting rid of repititions of delete dialogs and stuff, but do it in a other pr merging this for now great work ! |
|
@VineeTagarwaL-code |
closes the issue #548
fffff.mp4