Dropdown Component + some general adjustments #21
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/base-ui/-/pipelines/1110814035 Status: Passed Job summariesstorybook:buildStorybook available at https://code0-tech.gitlab.io/-/base-ui/-/jobs/5772652264/artifacts/storybook-static/index.html |
|
|
|
Issue resolved with 568d42c |
|
I will give it a quick self review, because no one is online right now and I am the project lead anyway |
|
Lets keep the branch for now, so @Taucher2003 or @raphael-goetz can give it a good review later |
| @@ -67,5 +65,8 @@ | |||
| }, | |||
| "publishConfig": { | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "rollup-plugin-visualizer": "^5.11.0" | |||
There was a problem hiding this comment.
Is this intended to be a dependency instead of a dev devependency? Based on the name, I would expect it as dev dependency.
There was a problem hiding this comment.
Yep, that's a mistake. Will be changed in a future MR.
| } | ||
|
|
||
| /** | ||
| * Component creates an item with over effect |
There was a problem hiding this comment.
What the hell is an "over effect"?
There was a problem hiding this comment.
Just a typo, will be fixed within a future MR.
| } | ||
|
|
||
| /** | ||
| * Component creates an item with over effect |
There was a problem hiding this comment.
Same here, what is an "over effect"?
There was a problem hiding this comment.
Just a typo, will be fixed within a future MR.
There was a problem hiding this comment.
Instead of having a utils.ts inside a utils folder, I think this should be split for better readability and easier understanding.
I think this could be split into utils/react_nodes.ts and utils/positions.ts.
There was a problem hiding this comment.
Because this is already merged, I will convert your ideas into issues.
No description provided.