Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#51: ignore angostura_connection #52

Merged
merged 1 commit into from
Apr 17, 2021
Merged

#51: ignore angostura_connection #52

merged 1 commit into from
Apr 17, 2021

Conversation

marianelamin
Copy link
Collaborator

Changed made, testing workflow.

@marianelamin marianelamin linked an issue Apr 4, 2021 that may be closed by this pull request
@marianelamin marianelamin added the enhancement New feature or request label Apr 4, 2021
@asciidiego
Copy link
Collaborator

is there a place that shows how angostura_connection.json works? Like the schema? If that is the case, LGTM!

Otherwise, could we add a sample file or explain what is the purpose of the file somewhere? :)

@marianelamin
Copy link
Collaborator Author

Good point. We need this to be able to connect to bigquery and read of their tables.
As far as I know there are no documents that describe this.. will work on this to have it added.

@asciidiego
Copy link
Collaborator

Good point. We need this to be able to connect to bigquery and read of their tables.
As far as I know there are no documents that describe this.. will work on this to have it added.

Got it. Created a new issue @ #63.

Now it LGTM! :)

@asciidiego asciidiego merged commit a24a0cb into master Apr 17, 2021
@asciidiego asciidiego deleted the feature/i51 branch April 17, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Issue
3 participants