Fix issue #2587: playback speed shortcut works when manually saved or reset by user #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi and thanks! @aryeh-bloom We don't set defaults (intentionally), but YouTube got default shortcuts ( #1565looking forward! ( #664 ) |
|
Great, thank you @ImprovedTube for letting me know! Would you also like for me to add the disclaimer to all of the shortcuts? |
|
Hi! @aryeh-bloom. Please confirm, that we don't set any defaults, but we just inform about Youtube's default (see #517) , we (just) need to improve this for clarity and convenience. (And don't need the disclaimer above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shortcut does not initialize with the key binds saved once the extension is downloaded, so you have to manually click each one and hit 'save' for it to start working. Once saved, they will continue to work indefinitely. I added an informational message within the shortcut's tab to convey that this may be the case for some users.