Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2587: playback speed shortcut works when manually saved or reset by user #2593

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aryeh-bloom
Copy link

The shortcut does not initialize with the key binds saved once the extension is downloaded, so you have to manually click each one and hit 'save' for it to start working. Once saved, they will continue to work indefinitely. I added an informational message within the shortcut's tab to convey that this may be the case for some users.

@ImprovedTube
Copy link
Member

hi and thanks! @aryeh-bloom
Glad you went this far understanding our GUI code! 🥰

We don't set defaults (intentionally), but YouTube got default shortcuts (top right corner on youtube: keyboard shortcuts),
so we display them in our GUI too (They aren't the same, just approaching a full / seamless experience.)

Youtube's defaults: #517 #110 #1566.

#1565

looking forward!

( #664 )

@aryeh-bloom
Copy link
Author

aryeh-bloom commented Sep 30, 2024

Great, thank you @ImprovedTube for letting me know! Would you also like for me to add the disclaimer to all of the shortcuts?

@ImprovedTube
Copy link
Member

Hi! @aryeh-bloom. Please confirm, that we don't set any defaults, but we just inform about Youtube's default (see #517) , we (just) need to improve this for clarity and convenience. (And don't need the disclaimer above)
(Correct me if i'm wrong)
Thanks! :)

@ImprovedTube ImprovedTube marked this pull request as draft October 2, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants