-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more default setting work #2262
Conversation
dont abuse variant for class more default work remove optional cancels new switch variant: 'manual'
1. default:true vs. 2 inverted switches (1. which shall be listed in active features too by default, 2. which are just "trashbin candidates" together with everything called hide / remove and a list of youtubes experiment flags )
Might first start collecting statistics. Since the amount (=toggled off) represents the past and might point to bugs etc. already (besides that the future data will be better in that, and this might also just define curious users, who tried everything and busy users who didnt.) |
1 No need, this commit works as is. nothing else needs to be changed.
still works fine with this commit. Every time config variable gets removed a message reflecting that is still send and triggers youtube/js&css/web-accessible/core.js Line 140 in f6b84f3
more perils of faking showing something enabled by default. "my active features" shows only things User changed from defaults. this is why I abandoned by rewrite of those buttons https://github.com/raszpl/YouTube-Extension/commits/repeat-wip/ imo they dont work well
something like https://www.oo-software.com/en/shutup10 asks if you want to apply recommended settings before letting user custom configure. Maybe an option called "apply recommended settings", or "show recommended settings". Can work like "my active features" listing only differences between current and recommended with recommended selection flashing green or something.
why invert something twice? :o Im thinking of a way for automatically visualize select/switch/slider/colorPicker default selection in certain way so User can clearly see whats the default when switching.
statistics are cool and all, but think about privacy and Google policies. Slurping user data, no matter how trivial, without consent is a big no no and might end up banning the extension.
Only Google/Microsoft/Facebook are allowed to do that :) |
hi! @raszpl
Not those checking for " === false" , like transcript. (Can only be switched off live without #2262.) Need to search the repo for === false ( and === true for those "default true"'s which aren't actually "default-true"'s but inverted switches )
yes! See: #377 (comment) And yesterday: #2086 (comment) (This will be good for most users and increase use (Since many people dont) use many extensions, and just want to find something on the youtube side itself. You might also remember Magic actions for youtube's little player button expanding as a 3x3 or so (may it changed by now)
sorry, they be 0x inversion but just 1x visual variant somehow maybe? ( check box/toggle: off = in the trashbin = lights off. )
yes, good for sliders! while a normal checkboxes or toggles should be very obvious already (a 3-way toggle can use a dot too -1 0 1)
#1972 (comment) |
to be merged after removing the inverted switches? (but labeling them for performance or for tidying and or giving them an inverted toggle that's lighted when off (toggle on the left) and in a different color) - Or just checking that none of them checks for === true) (and we can make defaults appear in active settings) |
It was soo long I will need to go over the code again to resolve all merge conflicts
this part threw me off:
The way I see it any feature that relied on this behavior was broken by design. It lied to user :)
Thats the next exciting step! Try to design a clever way of conveying that information. A small image with "default" text? a different color? an icon? Im not great at designing new visual things :-) |
Was watching a movie just now when it hit me - NO. We dont need to change anything for those = |
purpose was only store true #1685, so cant check === false for |
This covers all switching functions:
select
switch
checkbox
slider
colorPicker
Now picking default option/value automatically removes config variable from storage.
Next step after merging this will be adding function pruning config from unneeded default stored variables for all users called on extension update. After that we can finally start optimizing /web-accessible/ code.