Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update player.js quick bodge fix for #2137 #2242

Merged
merged 3 commits into from
May 4, 2024
Merged

Update player.js quick bodge fix for #2137 #2242

merged 3 commits into from
May 4, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented May 4, 2024

#2137

do nothing if we fail to grab video element in time

@ImprovedTube
Copy link
Member

should've merged #2157 already

@ImprovedTube ImprovedTube merged commit 1cf7905 into code-charity:master May 4, 2024
@ImprovedTube
Copy link
Member

if(!video) {console.log("no video - no pause"); return;}
or retry after some ms?


(can also likely undo the if (!ImprovedTube.autoplayDeniedOnce) as said in the other tread)

@raszpl raszpl deleted the patch-3 branch May 4, 2024 19:02
@raszpl
Copy link
Contributor Author

raszpl commented May 4, 2024

should've merged #2157 already

that one just made the code look nicer, didnt change functionality

(can also likely undo the if (!ImprovedTube.autoplayDeniedOnce) as said in the other tread)

definitely this :) Iv been running my local copy with
//ImprovedTube.autoplayDeniedOnce = true;
for ~month now with no ill effects. I believe the source of users clicking on video multiple times and not getting it to play was due to #2177

if(!video) {console.log("no video - no pause"); return;} or retry after some ms?

Retry might be a bad idea on events, a lot can change between triggering and trying again, like new page loaded in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants