Update player.js cleanup listeners after option switch

code-charity · Jun 15, 2024 · 34dbe04 · 34dbe04
1 parent f04d981
commit 34dbe04
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/js&css/web-accessible/www.youtube.com/player.js b/js&css/web-accessible/www.youtube.com/player.js
@@ -988,9 +988,7 @@ ImprovedTube.playerControls = function () {
 
 	if (player && player.hideControls && player.showControls) {
 
-		if (hide === 'always') {
-			player.hideControls();
-		} else if (hide === 'when_paused' && this.elements.video.paused) {
+		if (hide === 'when_paused' && this.elements.video.paused) {
 			player.hideControls();
 
 			player.onmouseenter = player.showControls;
@@ -1004,9 +1002,15 @@ ImprovedTube.playerControls = function () {
 					thread = setTimeout(player.hideControls, 1000);
 				};
 			})();
+			return;
+		} else if (hide === 'always') {
+			player.hideControls();
 		} else {
 			player.showControls();
 		}
+		player.onmouseenter = null;
+		player.onmouseleave = null;
+		player.onmousemove = null;
 	}
 };
 /*#  HIDE VIDEO TITLE IN FULLSCREEN	*/			  // Easier with CSS only (see player.css)