-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for verbatimModuleSyntax with the umi renderer #240
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for tackling this in the Umi renderer but I think it'd be better if this implementation was consistent with the new web3.js renderer.
If you look at the renderers-js
package, you'll see type MyType
is supported and each type import must explicitly tell us it wants a type by important "type MyType"
. Then, on the ImportMap
, we ensure that if we receive both "type MyType"
and "MyType"
, then we only import the latter.
Hmm okay, I tried this first, but some imports were generated directly from shared types, but I will look into it if I stumble onto any issues further down |
Btw, Is there any community discord or anything for this project/solana open source in general? |
We didn't have a dedicated place for these sort of conversations (more like dozens of small Telegram groups haha) but we do now! We added a channel directly under the "Dev Tooling" section of the "Solana Tech" server on Discord. Here's the link. https://discord.com/channels/428295358100013066/1295768706806321264 |
Cool! |
This adds a "fixer" for all imports so if they are PascalCase they get a type prefix which makes the renderer compatible with verbatimModuleSyntax