refactor codes #17793
Merged
refactor codes #17793
+329
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cocos-robot run test cases |
minggo
commented
Oct 31, 2024
| return result; | ||
| if (!this.horizontal) vector.x = 0; | ||
| if (!this.vertical) vector.y = 0; | ||
| return vector; |
minggo
commented
Oct 31, 2024
| @@ -1536,96 +1580,100 @@ export class ScrollView extends ViewGroup { | |||
| _tempVec3_1.set(_tempVec2_1.x, _tempVec2_1.y, 0); | |||
| uiTransformComp.convertToNodeSpaceAR(_tempVec3, _tempVec3); | |||
| uiTransformComp.convertToNodeSpaceAR(_tempVec3_1, _tempVec3_1); | |||
| Vec3.subtract(vec, _tempVec3, _tempVec3_1); | |||
| Vec3.subtract(out, _tempVec3, _tempVec3_1); | |||
There was a problem hiding this comment.
Just use out instead, don't have to create a new temple object vec.
👍 Package size ⤵ -1030 bytes, old: 5429602, new: 5428572Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
commented
Oct 31, 2024
| const item = listener; | ||
|
|
||
| if (this.node === item) { | ||
| if (this.node === listener) { |
There was a problem hiding this comment.
item is not needed, just delete it.
minggo
commented
Oct 31, 2024
| clonedDeltaMove.multiplyScalar(factor); | ||
| targetDelta.set(clonedDeltaMove); | ||
| targetDelta.set(deltaMove); | ||
| targetDelta.multiplyScalar(factor + 1); |
There was a problem hiding this comment.
// clonedDeltaMove = deltaMove
const clonedDeltaMove = deltaMove.clone();
// clonedDeltaMove = clonedDeltaMove * factor = deltaMove * factor
clonedDeltaMove.multiplyScalar(factor);
// targetDelta = clonedDeltaMove = deltaMove * factor
targetDelta.set(clonedDeltaMove);
// targetDelta = targetDelta + deltaMove = deltaMove * factor + deltaMove = deltaMove * (factor + 1)
targetDelta.add(deltaMove); 
There was a problem hiding this comment.
Why does the factor need to be increased?
There was a problem hiding this comment.
Please refer to the comment above.
minggo
commented
Oct 31, 2024
| @@ -1240,13 +1276,12 @@ export class ScrollView extends ViewGroup { | |||
|
|
|||
| const originalMoveLength = deltaMove.length(); | |||
| let factor = targetDelta.length() / originalMoveLength; | |||
| targetDelta.add(deltaMove); | |||
There was a problem hiding this comment.
as targetDelta will be set in if (this.brake > 0 && factor > 7), so move it to else block bellow.
|
@minggo, Please check the result of
Task Details |
|
@minggo, Please check the result of
Task Details |
qiuguohua
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #17715