Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.5] Don't export spine enums in c++ since they're defined in spine-core.js. #17759

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Oct 22, 2024

And using _enum will generate a different enum format like var TimelineType = { rotate: { value: 0} }; rather than var TimelineType = { rotate: 0 };

And MathUtil should also be defined in spine-core.js which will make better performance. I will do it in another PR.

Re: #17715

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

And using `_enum` will generate a different enum format like `var TimelineType = { rotate: { value:  0}  }; ` rather than `var TimelineType = { rotate: 0 };`
@dumganhar dumganhar requested a review from minggo October 22, 2024 01:47
Copy link

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar merged commit 1fa8897 into cocos:v3.8.5 Oct 22, 2024
16 of 25 checks passed
dumganhar added a commit to dumganhar/cocos-engine that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants