get rid of unnecessary uses of unsafe #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
reviewed
Sep 24, 2024
It turns out all of our uses of unsafe in this module can be trivally replaced by uses of the zerocopy crate. Signed-off-by: Tom Dohrmann <[email protected]>
Once again, zerocopy can do everything we needed without us using unsafe. Signed-off-by: Tom Dohrmann <[email protected]>
The new implementation is much shorter, should perform exactly the same and doesn't even rely on unsafe. Signed-off-by: Tom Dohrmann <[email protected]>
zerocopy is great :) Signed-off-by: Tom Dohrmann <[email protected]>
We can make use of the `Deref` and `DerefMut` implementations. Signed-off-by: Tom Dohrmann <[email protected]>
Freax13
force-pushed
the
zeroooooo-copyyyy
branch
from
65593dd
to
9ec1021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR get's rid of some unnecessary uses of unsafe mainly by switching to safe alternatives provided by the zerocopy crate.