Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colblk: cache KeyspanDecoder in block metadata #4082

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

RaduBerinde
Copy link
Member

No description provided.

@RaduBerinde RaduBerinde requested a review from a team as a code owner October 19, 2024 20:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @RaduBerinde)


sstable/colblk/data_block.go line 774 at r1 (raw file):

	defer func() {
		if r := recover(); r != nil {
			err = base.CorruptionErrorf("error initializing data block metadata: %v", r)

nit: should we say "index block metadata"


sstable/colblk/data_block.go line 794 at r1 (raw file):

	defer func() {
		if r := recover(); r != nil {
			err = base.CorruptionErrorf("error initializing data block metadata: %v", r)

and "keyspan block metadata"

@RaduBerinde RaduBerinde merged commit ced78c3 into cockroachdb:master Oct 20, 2024
23 checks passed
Copy link
Member Author

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion


sstable/colblk/data_block.go line 794 at r1 (raw file):

Previously, jbowens (Jackson Owens) wrote…

and "keyspan block metadata"

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants