Add pod security policy #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@himanshu-cockroach can you take a look at this? |
prafull01
reviewed
Sep 15, 2023
|
@bkochendorfer Please rebase your branch with latest change |
This adds pod security policy and seccompprofile.
bkochendorfer
force-pushed
the
seccompprofile
branch
from
e45660d
to
a26b28a
Compare
prafull01
reviewed
Sep 15, 2023
prafull01
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pod security policy and
seccompProfile. I was unable to get the Helm chart to install locally to verify that these changes work when tls is enabled and the self signer is enabled, this seems to be the default configuration based on values. Whenever I attempt to do this I always get errors that the serviceaccount, roles, and rolebinding already exist due to how the annotations are being set manually. I'm not familiar enough with this chart to know if we should change those to include the release-name so that a subsequent run does not try to recreate them.If I could get this to work locally I believe I will also need to resources in the jobs
job-certSelfSignerandjob-cleaneras we require setting resource limits/requests everywhere.