Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drtprod: dynamic pgurl of crdb nodes on workload #136187

Merged

Conversation

shailendra-patel
Copy link
Contributor

In generate_tpcc_run.sh add ability to specify crdb nodes offset while getting pgurl instead of hardcoding pgurls.

Epic: none

Release note: None

In `generate_tpcc_run.sh` add ability to specify crdb nodes
offset while getting pgurl instead of hardcoding pgurls.

Epic: none

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@shailendra-patel shailendra-patel marked this pull request as ready for review November 26, 2024 06:51
@shailendra-patel shailendra-patel requested a review from a team as a code owner November 26, 2024 06:51
@shailendra-patel shailendra-patel requested review from DarrylWong, vidit-bhat and nameisbhaskar and removed request for a team November 26, 2024 06:51
Copy link
Contributor

@nameisbhaskar nameisbhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shailendra-patel
Copy link
Contributor Author

TFTR @nameisbhaskar

bors r=nameisbhaskar

@craig craig bot merged commit d9fa871 into cockroachdb:master Nov 26, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants