raft: set electionElapsed to electionTimeout in defortify() regardless of state #136025
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…s of state Previously, we use to set electionElapsed to electionTimeout inside defortify() only when we are not the leader. We did this as an extra defense because we didn't want to increment the electionTimeout when we are the leader. However, there is no need for this extra complexity since in all cases where we call defortify when we are the leader, we either immediately step down (which resets the electionElapsed to 0), or we are okay performing a checkQuorum (in the case where a leader receive a MsgPreVote from a higher term while it's not in leader-lease) Epic: None Release note: None
iskettaneh
force-pushed
the
ForgetLeader0
branch
from
effef05
to
09920b8
Compare
arulajmani
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
134990: raft: forget the leader when stepping down if it's safe r=iskettaneh a=iskettaneh First commit is based on #136025 This PR makes the leader forget that it was the leader when stepping down if it's safe to do so. The places this PR changes: 1) When stepping down due to CheckQuorum. 2) When stepping down due to leadership transfer. 3) When stepping down due to becoming a learner. 4) After a restart. 5) After a VoteLoss. Epic: none Release note: None Co-authored-by: Ibrahim Kettaneh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we use to set electionElapsed to electionTimeout inside defortify() only when we are not the leader. We did this as an extra defense because we didn't want to increment the electionTimeout when we are the leader. However, there is no need for this extra complexity since in all cases where we call defortify when we are the leader, we either immediately step down (which resets the electionElapsed to 0), or we are okay performing a checkQuorum (in the case where a leader receive a MsgPreVote from a higher term while it's not in leader-lease)
Epic: None
Release note: None