Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: make cockroach-microbench-ci as required #135899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −4
Open

workflows: make cockroach-microbench-ci as required #135899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/bors.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ status = [
"macos_arm64_build",
"unit_tests",
"windows_build",
"cockroach-microbench-ci",
]

# List of commit statuses that must not be failing on the PR commit when it is
Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/github-actions-essential-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,21 @@ jobs:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
- name: compute metadata
run: echo GITHUB_ACTIONS_BRANCH=${{ github.event.pull_request.number || github.ref_name}} >> "$GITHUB_ENV"
- name: Check for 'performance-regression-expected' label
uses: actions/github-script@v6
with:
script: |
const labelToCheck = 'performance-regression-expected';
const { owner, repo } = context.repo;
const issue_number = context.payload.pull_request.number;
const labels = await github.rest.issues.listLabelsOnIssue({
owner,
repo,
issue_number
});
const labelNames = labels.data.map(label => label.name);
const hasLabel = labelNames.includes(labelToCheck);
core.exportVariable('PERF_REGRESSION', hasLabel ? 'true' : 'false');
- run: ./build/github/get-engflow-keys.sh
- run: ./build/github/prepare-summarize-build.sh
- name: run scripts
Expand All @@ -384,9 +399,7 @@ jobs:
COMPARE_THRESHOLD: "20.00"
PUSH_STEP: ${{ github.event_name == 'push' && env.GITHUB_ACTIONS_BRANCH != 'staging' }}
BASE_SHA: ${{ steps.get_latest_commit_target_branch.outputs.latest_commit }}

# TODO(sambhav-jain-16): add Performance note check and use this flag. Currently set to false (https://github.com/cockroachdb/cockroach/issues/106661)
SKIP_COMPARISON: ${{ env.GITHUB_ACTIONS_BRANCH == 'staging' }}
SKIP_COMPARISON: ${{ env.GITHUB_ACTIONS_BRANCH == 'staging' && env.PERF_REGRESSION }}
- name: upload build results
run: ./build/github/summarize-build.sh bes.bin
if: always()
Expand Down
1 change: 0 additions & 1 deletion build/github/cockroach-microbench-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ bazel test //pkg/sql/tests:tests_test \
--test_arg=-test.run=- \
--test_arg='-test.bench=^BenchmarkKV$' \
--test_sharding_strategy=disabled \
--test_arg=-test.cpu --test_arg=1 \
--test_arg=-test.v \
--test_arg=-test.count=10 \
--test_arg=-test.benchmem \
Expand Down
Loading