build/teamcity: add changes to enable openmetrics in nightly roachtests #135564
+67
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
bce8483
to
27d564d
Compare
sambhav-jain-16
changed the title
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
9 times, most recently
from
824ae4b
to
0181b51
Compare
|
Test runs: |
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
0181b51
to
596260c
Compare
sambhav-jain-16
requested review from
srosenberg and
nameisbhaskar
and removed request for
a team
DarrylWong
reviewed
Nov 25, 2024
There was a problem hiding this comment.
I think there's a couple benchmark tests that are on the weekly suite. We should export -e EXPORT_OPENMETRICS -e ROACHPERF_OPENMETRICS_CREDENTIALS to the weekly_*.sh scripts as well.
There was a regression in #135239.
Out of curiosity, what exactly was the regression?
An error was introduced while trying to read
ok |
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
596260c
to
1f45770
Compare
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
1f45770
to
1ea21b5
Compare
There was a regression in cockroachdb#135239. The change was reverted and this PR aims to fix the regressions Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
1ea21b5
to
dcbff22
Compare
|
TFTR! bors r=@nameisbhaskar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in #135239.
The change was reverted and this PR aims to fix the regressions
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852
Release note: None