changefeedccl: make changefeed_emitted_bytes work for core changefeeds #135292
+86
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
andyyang890
force-pushed
the
20241115-changefeed-spec-description
branch
8 times, most recently
from
053ad32
to
a1d2434
Compare
andyyang890
force-pushed
the
20241115-changefeed-spec-description
branch
from
a1d2434
to
5cb5c17
Compare
andyyang890
requested review from
rharding6373,
asg0451 and
a team
and removed request for
a team
This patch makes `changefeed_emitted_bytes` structured log events work for core changefeeds. It also adds the changefeed description to the aggregator and frontier specs so that a processor doesn't need to load the job just to get the description and changefeeds that don't use jobs (i.e. core changefeeds) can also pass along a description. Release note: None
andyyang890
force-pushed
the
20241115-changefeed-spec-description
branch
from
5cb5c17
to
30eca1b
Compare
andyyang890
added
backport-23.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
changefeed_emitted_bytesstructured log events workfor core changefeeds. It also adds the changefeed description to the
aggregator and frontier specs so that a processor doesn't need to load
the job just to get the description and changefeeds that don't use jobs
(i.e. core changefeeds) can also pass along a description.
Informs: #135309
Release note: None