azure: Upgrade azidentity library and dependencies to 1.8.0 #134887
Conversation
|
This change is |
benbardin
requested review from
adwittumuluri,
a team,
kev-cao and
msbutler
and removed request for
a team and
kev-cao
|
@benbardin did you run the cloud unit tests as well? Also, could you update the commit message to follow protocol? https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/73072807/Git+Commit+Messages |
benbardin
force-pushed
the
az-upgrade
branch
2 times, most recently
from
c4796fd
to
4cbc4e4
Compare
benbardin
changed the title
benbardin
changed the title
|
Updated commit message. Adwit didn't think there was anything reasonable to do beyond the testing I've done - roachtests, unit tests, manual tests. It will be very hard to make the cloud tests work with an unpublished SHA, so as far as cloud goes I don't think there's much we can reasonably do until we cut a 25.1 beta. |
benbardin
force-pushed
the
az-upgrade
branch
from
4cbc4e4
to
38a33f2
Compare
Release note: None Epic: CRDB-42520
benbardin
force-pushed
the
az-upgrade
branch
from
38a33f2
to
5109e47
Compare
| @@ -10,14 +10,14 @@ go 1.22.8 | |||
| // merge of any upgrades we should communicate to all teams to be on the lookout | |||
| // for behavior changes, just like we would after a go upgrade. | |||
| require ( | |||
| golang.org/x/crypto v0.26.0 | |||
| golang.org/x/crypto v0.27.0 | |||
There was a problem hiding this comment.
argh, note the above comment. these core dep upgrades need to be in their own commit. I wonder if we'll get these upgrades for free when dev inf upgrades to go 1.23. Maybe ask dev inf on their timeline for that?
There was a problem hiding this comment.
oh, very good eye. thanks for noticing!
|
We can just use azure 1.7.0, it doesn't need the crypto upgrade and we only need to get >=1.6. Thanks! |
Manually ran available Azure roachtests here.
(One test failed, known flake.)
CRDB cloud tests here One failure, but is also exists on master