Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: roachtest: make failover timeouts less aggressive #132955

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 18, 2024

Backport 1/1 commits from #132931 on behalf of @nvanbenschoten.

/cc @cockroachdb/release


Fixes #132830.

This commit increases the timeout for various failover test from 30 minutes to 45 minutes. Each of these tests performs 9 iterations of failover which takes at least 2 minutes per iteration, plus rebalance time and failover time. That gives the test little tolerance for slowness or temporary instability. Since the point of these tests has nothing to do with the timeout, we can afford to be more lenient to avoid flakiness.

Release note: None


Release justification: test only

Fixes #132830.

This commit increases the timeout for various `failover` test from 30
minutes to 45 minutes. Each of these tests performs 9 iterations of
failover which takes at least 2 minutes per iteration, plus rebalance time
and failover time. That gives the test little tolerance for slowness or
temporary instability. Since the point of these tests has nothing to do
with the timeout, we can afford to be more lenient to avoid flakiness.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 18, 2024 19:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-132931 branch from 4cc6a00 to e6f0d03 Compare October 18, 2024 19:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 18, 2024
@blathers-crl blathers-crl bot requested review from nameisbhaskar and vidit-bhat and removed request for a team October 18, 2024 19:02
Copy link
Author

blathers-crl bot commented Oct 18, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 18, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit 39bae3f into release-24.1 Oct 18, 2024
19 of 20 checks passed
@nvanbenschoten nvanbenschoten deleted the blathers/backport-release-24.1-132931 branch October 18, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants