Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: sql/colexec: fix projection and selections with constant NULL values #132947

Merged
merged 2 commits into from
Oct 18, 2024
Merged

release-24.1: sql/colexec: fix projection and selections with constant NULL values #132947

merged 2 commits into from
Oct 18, 2024

Conversation

mgartner
Copy link
Collaborator

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: Low-risk bug fixes.

@mgartner
colexec: fix projections with constant NULL values
a1070f8 
This commit fixes a bug in the vectorized engine that caused incorrect
results when projections operated on constant NULL values. The
`proj_const_right_ops` operators do not correctly handle NULL inputs.
So, we avoid these code paths when operator does not operate on NULL
values and the RHS of an operator is NULL by simply projecting NULLs.

Fixes cockroachdb#127814

Release note (bug fix): A bug has been fixed that could cause incorrect
evaluation of scalar expressions involving `NULL` values in rare cases.
@mgartner
sql/colexec: fix selection comparisons with NULL
191a7e8 
This commit fixes a bug in the vectorized engine that caused incorrect
results when selections operated on constant NULL values. The selection
operators, like `selNEDatumDatumConstOp`, do not correctly handle NULL
inputs. So, we avoid these code paths when an operator should not be
called on NULL values by constructing a zero operator.

Fixes cockroachdb#130759

Release note (bug fix): A bug has been fixed that could cause incorrect
evaluation of scalar expressions involving NULL values in rare cases.
@mgartner mgartner requested a review from a team October 18, 2024 18:10
@mgartner mgartner requested a review from a team as a code owner October 18, 2024 18:10
@mgartner mgartner requested review from michae2 and removed request for a team October 18, 2024 18:10
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 18, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 18, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner changed the title release-24.1: sql/colexec: fixed proejctions and selections with constant NULL values release-24.1: sql/colexec: fix projection and selections with constant NULL values Oct 18, 2024
michae2
michae2 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner merged commit 7b1394c into cockroachdb:release-24.1 Oct 18, 2024
19 of 20 checks passed
@mgartner mgartner deleted the backport24.1-128123-132261 branch October 18, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michae2 michae2 michae2 approved these changes

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgartner @cockroach-teamcity @michae2