release-24.3: server: don't Fatal in response to cluster setting #132937
+13
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #132829 on behalf of @stevendanna.
/cc @cockroachdb/release
This cluster setting is protecting in-development features. While we don't expect users to ever set this, if a user were to happen to find the cluster setting and enable it, we don't want that to result in a process crash.
Here, we add a validation such that the user can't set the relevant setting to true in production and also remove a log.Fatal just in case.
Epic: none
Release note: None
Release justification: Low risk fix for a node crashing behaviour.