sql, ui: introduce sql.crud_query.count QPS metric
#132922
Open
+33
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhartunian
requested review from
a team,
arjunmahishi and
aa-joshi
and removed request for
a team
dhartunian
requested review from
angles-n-daemons
and removed request for
a team
Previously, customers struggled to get an accurate picture of "QPS" on a cluster, due to a number of factors. First, our `sql.query.count` metric includes counts of transaction control statements which greatly inflate the "QPS" in a confusing way to a customer. Second, the Metrics page in DB Console included a "QPS" metric which was a client-side sum of the insert/update/delete/select counters. This metric wasn't available to scrape or view in line graphs which led to confusion. In this PR we introduce the `sql.crud_query.count` and `sql.crud_query.started.count` metric which is incremented along with the insert/update/delete/select counters. This metric is added to the SQL chart at the top of the overview dashboard. That chart is renamed to have the title `SQL Queries Per Second` for clarity and the box on the right hand side now uses this metric directly. Resolves: CRDB-25876 Epic: CRDB-37557 Release note (ops change): Two new metrics are available `sql.crud_query.count` and `sql.crud_query.started.count` which measure the number of insert/update/delete/select queries executed and started respectively.
|
This change is |
dhartunian
force-pushed
the
add-qps-metric
branch
from
822810a
to
4d99190
Compare
dhartunian
changed the title
crud_query.count QPS metricsql.crud_query.count QPS metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, customers struggled to get an accurate picture of "QPS" on a cluster, due to a number of factors.
First, our
sql.query.countmetric includes counts of transaction control statements which greatly inflate the "QPS" in a confusing way to a customer.Second, the Metrics page in DB Console included a "QPS" metric which was a client-side sum of the insert/update/delete/select counters. This metric wasn't available to scrape or view in line graphs which led to confusion.
In this PR we introduce the
sql.crud_query.countandsql.crud_query.started.countmetric which is incremented along with the insert/update/delete/select counters.This metric is added to the SQL chart at the top of the overview dashboard. That chart is renamed to have the title
SQL Queries Per Secondfor clarity and the box on the right hand side now uses this metric directly.Resolves: CRDB-25876
Epic: CRDB-37557
Release note (ops change): Two new metrics are available
sql.crud_query.countandsql.crud_query.started.countwhich measure the number of insert/update/delete/select queries executed and started respectively.