release-24.1: sql: add old zone config in zone config logs #132896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/3 commits from #132677.
/cc @cockroachdb/release
sql: add old zone config in zone config logs
This patch adds another field in
eventpb.SetZoneConfig
.This field,
ResolvedOldConfig
, will aid in logging the zone configurationthat we have changed.
We use the
completeZone/completeSubzone
here because we want tobe more useful in our zone config logging. The benefit of using the
complete* is that we can explicitly see what fields are changing,
even if they are actually modeled as a zone config that just inherits
from its parent. The disadvantage of this is that we are not able
to easily tell the inheritence of the old zone config, but knowing
the actual diff between the old vs new config seems more relevant
for debugging.
Fixes: #127176
Release note: None
Release justification: low-risk logging improvement