drtprod: add tpcc_run.sh to workload-scale #132881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add the `tpcc_run.sh` to all `workload-scale` nodes. The script distributes the `PGURLS` equally amongst the workload nodes. Epic: none Release note: None
|
This change is |
vidit-bhat
requested review from
herkolategan,
DarrylWong,
nameisbhaskar and
shailendra-patel
and removed request for
a team
|
|
||
| # Calculate number of larger and smaller groups | ||
| NUM_LARGER=$(( $CLUSTER_NODES % $WORKLOAD_NODES )) | ||
| NUM_SMALLER=$(( $WORKLOAD_NODES - NUM_LARGER )) |
There was a problem hiding this comment.
Suggested change
| NUM_SMALLER=$(( $WORKLOAD_NODES - NUM_LARGER )) | |
| NUM_SMALLER=$(( $WORKLOAD_NODES - $NUM_LARGER )) |
| exit 1 | ||
| fi | ||
|
|
||
| # Calculate group sizes |
There was a problem hiding this comment.
Please show an example in the comment explaining what each of these variables mean. How everything distributes the CRDB nodes to the workload nodes evenly.
| @@ -126,3 +124,11 @@ targets: | |||
| flags: | |||
| warehouses: 100000 | |||
| db: cct_tpcc | |||
| - script: "pkg/cmd/drtprod/scripts/tpcc_run.sh" | |||
There was a problem hiding this comment.
just to avoid confusion, can we rename the script to be generate_tpcc_run.sh or something?
| @@ -21,7 +23,7 @@ targets: | |||
| gce-managed: true | |||
| gce-enable-multiple-stores: true | |||
| gce-zones: "us-central1-a" | |||
| nodes: 150 | |||
| nodes: $CLUSTER_NODES | |||
| gce-machine-type: n2-standard-16 | |||
| local-ssd: true | |||
| gce-local-ssd-count: 4 | |||
There was a problem hiding this comment.
It may be beneficial to make this a env variable as well as this is used in 2 places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the
tpcc_run.shto allworkload-scalenodes. The script distributes thePGURLSequally amongst the workload nodes.Epic: none
Release note: None