storage: add cluster setting delete_compaction_excise.enabled #132870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * [`1d2e9e82`](cockroachdb/pebble@1d2e9e82) options: add EnableDeleteOnlyCompactionExcises Option Release note: none. Epic: none.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
aadityasondhi
approved these changes
Oct 17, 2024
nicktrav
reviewed
Oct 17, 2024
| "set to false to direct Pebble to not partially excise sstables in delete-only compactions", | ||
| metamorphic.ConstantWithTestBool( | ||
| "storage.delete_compaction_excise.enabled", true), /* defaultValue */ | ||
| settings.WithPublic) |
There was a problem hiding this comment.
Driveby: should this be a public setting?
There was a problem hiding this comment.
I think there's a good argument for it to go either way. For now I just copied the same visibility as some of the other compaction-y settings like ingest_split.enabled above.a
itsbilal
force-pushed
the
bilal/pebble-master-1d2e9e829b92
branch
2 times, most recently
from
2904c94
to
8dc3169
Compare
This change adds a cluster setting to be able to dynamically disable excises in delete-only compactions. Excises allow for range deletions / range key deletions to be applied to sstables even if they don't fully overlap with the sstable; we just produce virtual sstables for the remainder of the sstable. Epic: none Release note: None
itsbilal
force-pushed
the
bilal/pebble-master-1d2e9e829b92
branch
from
8dc3169
to
75fb9ef
Compare
|
TFTR! bors r=aadityasondhi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a cluster setting to be able to dynamically
disable excises in delete-only compactions. Excises allow
for range deletions / range key deletions to be applied to
sstables even if they don't fully overlap with the sstable;
we just produce virtual sstables for the remainder of the sstable.
Epic: none
Release note: None