Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix TestAuthenticationAndHBARules stress tests SSL issue #132729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sql: fix TestAuthenticationAndHBARules stress tests SSL issue #132729

wants to merge 2 commits into from

Commits on Oct 19, 2024

  1. sql: fix TestAuthenticationAndHBARules stress tests SSL issue 

    informs cockroachdb#131532
informs cockroachdb#131110
informs cockroachdb#130253
informs cockroachdb#127745
Epic CRDB-41958

TestAuthenticationAndHBARules fails for `special_cases`,
`hba_default_equivalence`, `empty_hba` data driven tests for secure mode. The
failures occur when root user is trying to authenticate with cert-password auth
method and `sslmode` is set to `verify-ca` with `sslcert` being empty. The
expected behavior is root authentication defaults to password method and fails
as no password is set for root, but instead we get:
```
SSL is not enabled on the server
```
Since the failures are there only under stress, it might be because db server
shutdown or paused before responding to request for upgrade connection to SSL
from lib/pq client from here
https://github.com/lib/pq/blob/3d613208bca2e74f2a20e04126ed30bcb5c4cc27/conn.go#L1116-L1130.
Retrying connection establishment when this specific error is obtained might fix
the problem as this logic seems faulty(it checks for absence of 'S' in server
response whereas the correct check should be for 'N' in response).

Release note: None
    @souravcrl
    souravcrl committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5e62c2e View commit details
    Browse the repository at this point in the history

  2. pgwire: add test build logs for upgrade secure conn 

    Epic CRDB-41958

Additional test build logs are added to verify the step for which
`maybeUpgradeToSecureConn` fails for `TestAuthenticationAndHBARules`.

Release note: None
    @souravcrl
    souravcrl committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c81da1f View commit details
    Browse the repository at this point in the history