Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: change replica range lease to use NodeVitality #105091

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrewbaptist
Copy link
Collaborator

@andrewbaptist andrewbaptist commented Jun 16, 2023

This moves all the parts of the check into the NodeVitality interface to
simplify the conditions.

Epic: none

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 2 times, most recently from a447ac7 to 015f842 Compare June 16, 2023 23:09
@andrewbaptist andrewbaptist changed the base branch from 2023-06-16-liveness-cleanups to master June 16, 2023 23:10
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 6 times, most recently from 99b3489 to b4d15ad Compare June 21, 2023 13:50
@andrewbaptist andrewbaptist marked this pull request as ready for review June 21, 2023 16:08
@andrewbaptist andrewbaptist requested a review from a team June 21, 2023 16:08
@andrewbaptist andrewbaptist requested review from a team as code owners June 21, 2023 16:08
@andrewbaptist andrewbaptist requested review from a team June 21, 2023 16:08
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 5 times, most recently from 9aeb012 to 4fd3387 Compare June 21, 2023 22:36
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 6 times, most recently from b3878f6 to 388632d Compare June 26, 2023 19:44
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 5 times, most recently from 190b232 to 12d22e6 Compare June 27, 2023 22:11
@rafiss rafiss removed the request for review from a team July 18, 2023 21:01
@dhartunian dhartunian removed the request for review from a team August 30, 2023 14:04
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 2 times, most recently from 35e604d to 3227983 Compare December 18, 2023 20:24
@andrewbaptist andrewbaptist changed the title 2023 06 16 liveness cleanups kvserver: change replica range lease to use NodeVitality Dec 18, 2023
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 6 times, most recently from cfff65a to b784c7d Compare December 19, 2023 21:08
@andrewbaptist andrewbaptist marked this pull request as draft January 31, 2024 18:30
@andrewbaptist andrewbaptist force-pushed the 2023-06-16-liveness-cleanups branch 5 times, most recently from 6e3f0ae to 34ef29c Compare November 13, 2024 21:10
Previously node liveness wasn't constructed in tests. This commit adds
it to allow removing a number of nil checks.

Epic: none

Release note: None
As part of the effort to remove the IsLiveMap from the Store, all
non-lease related uses can be switched to directly use NodeVitality
directly.

Epic: none

Release note: None
This moves all the parts of the check into the NodeVitality interface to
simplify the conditions.

Epic: none

Release note: None
All the code has been changed to no longer require the GetIsLiveMap
function anymore.

Epic: none

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants