-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: change replica range lease to use NodeVitality #105091
Draft
andrewbaptist
wants to merge
4
commits into
cockroachdb:master
Choose a base branch
from
andrewbaptist:2023-06-16-liveness-cleanups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
kvserver: change replica range lease to use NodeVitality #105091
andrewbaptist
wants to merge
4
commits into
cockroachdb:master
from
andrewbaptist:2023-06-16-liveness-cleanups
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
2 times, most recently
from
June 16, 2023 23:09
a447ac7
to
015f842
Compare
andrewbaptist
changed the base branch from
2023-06-16-liveness-cleanups
to
master
June 16, 2023 23:10
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
6 times, most recently
from
June 21, 2023 13:50
99b3489
to
b4d15ad
Compare
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
5 times, most recently
from
June 21, 2023 22:36
9aeb012
to
4fd3387
Compare
Merged
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
6 times, most recently
from
June 26, 2023 19:44
b3878f6
to
388632d
Compare
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
5 times, most recently
from
June 27, 2023 22:11
190b232
to
12d22e6
Compare
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
from
July 17, 2023 14:56
12d22e6
to
9699ca5
Compare
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
2 times, most recently
from
December 18, 2023 20:24
35e604d
to
3227983
Compare
andrewbaptist
changed the title
2023 06 16 liveness cleanups
kvserver: change replica range lease to use NodeVitality
Dec 18, 2023
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
6 times, most recently
from
December 19, 2023 21:08
cfff65a
to
b784c7d
Compare
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
from
January 31, 2024 14:29
b784c7d
to
5d7e05a
Compare
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
5 times, most recently
from
November 13, 2024 21:10
6e3f0ae
to
34ef29c
Compare
Previously node liveness wasn't constructed in tests. This commit adds it to allow removing a number of nil checks. Epic: none Release note: None
As part of the effort to remove the IsLiveMap from the Store, all non-lease related uses can be switched to directly use NodeVitality directly. Epic: none Release note: None
This moves all the parts of the check into the NodeVitality interface to simplify the conditions. Epic: none Release note: None
All the code has been changed to no longer require the GetIsLiveMap function anymore. Epic: none Release note: None
andrewbaptist
force-pushed
the
2023-06-16-liveness-cleanups
branch
from
November 14, 2024 20:24
34ef29c
to
91058b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the parts of the check into the NodeVitality interface to
simplify the conditions.
Epic: none
Release note: None