Add testing support for OpenSUSE Tumbleweed #7143
Conversation
| # Setup user friendly names for multipath | ||
| printf 'defaults {\nuser_friendly_names yes\n}\n' > /etc/multipath.conf |
There was a problem hiding this comment.
I leave this up to you, but this is a smell. It's better to test the OS at it is for real users, and deal with the fallout in our code and tests. If this is a workaround for a bug in TW, it's useful to add a reference to it in a comment and prefix it with # HACK:. We use that a lot, then it remains greppable.
| @@ -98,6 +98,8 @@ if [ "${IMAGE%-i386}" != "$IMAGE" ]; then | |||
| fi | |||
|
|
|||
| zypper dup -y | |||
|
|
|||
| # Install default kernel for testing PLEASE REMOVE | |||
There was a problem hiding this comment.
Hmm, what's the condition to remove this? The comment below already gives the rationale.
| # cloud-init setups the wheel group incorrectly so we need to recreate it | ||
| groupdel wheel | ||
| zypper install -y system-group-wheel | ||
| sudo usermod -a -G wheel admin |
There was a problem hiding this comment.
This also feels like working around the OS, and should get a bug reference. In what way is "wheel" wrong? I.e. in a few months time how can developers decide if this can be dropped?
| @@ -37,7 +37,7 @@ echo "$spec" | rpmspec -D "$OS_VER_NO_VARIANT" -D 'version 0' -D 'enable_old_bri | |||
| # - nodejs for starter-kit and other projects which rebuild webpack during RPM build | |||
| case "$OS_VER" in | |||
| *suse*) | |||
| EXTRA_DEPS="appstream-glib rpmlint gettext-runtime desktop-file-utils nodejs-default" | |||
| EXTRA_DEPS="appstream-glib rpmlint gettext-runtime desktop-file-utils nodejs-default system-group-wheel" | |||
There was a problem hiding this comment.
This is for configure.ac to auto-detect --with-admin-group= presumably?
| # Setup redis | ||
| sudo cp /etc/redis/default.conf.example /etc/redis/redis.conf | ||
| sudo chown redis:redis /etc/redis/redis.conf | ||
|
|
||
| mkdir -p /etc/systemd/system/redis.target.d | ||
| cat > /etc/systemd/system/redis.target.d/70-redis-targets.conf <<EOF | ||
| [Unit] | ||
| [email protected] | ||
| EOF |
There was a problem hiding this comment.
Is that documented in TW somehow? That's all stuff that should either happen by default (to get an useful experience out of the box) or in Cockpit's metrics page. It doesn't help users if tests go green with "it works against a hacked up image", but not against a default install.
| [email protected] | ||
| EOF | ||
|
|
||
| systemctl enable --now redis.target |
There was a problem hiding this comment.
I'd advise against that. We don't enable it in Fedora/RHEL images by default, and even disable it in Debian. Most tests don't need it, and Cockpit's metrics page starts it if/when necessary.
| # use unpredictable network interface names | ||
| ln -s /dev/null /etc/systemd/network/99-default.link |
There was a problem hiding this comment.
This is another case of "please test the real-world default OS, not some hack". We fixed our projects to get along without hardcoded ethernet names a while ago, this really shouldn't be necessary.
This pairs with cockpit-project/cockpit#21335
This is aimed to add most of the support for testing Tumbleweed, let me know if you need any extra changes made to it