images: Go back to Fmstrat/samba-domain container #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 392d6b2 moved to quay.io/samba.org/samba-ad-server, but this has a serious and difficult bug [1] with connecting to the Global Directory. Go back to the previous https://github.com/Fmstrat/samba-domain container. The official dockerhub image actually works very well now, but we still have to build ourselves due to the docker.io pull rate limits. Also don't re-add the external volumes -- we are not interested in permanently keeping any Samba data. [1] samba-in-kubernetes/samba-container#160
cockpituous
changed the title
|
image-refresh services done: https://github.com/cockpit-project/bots/commits/image-refresh-services-20231122-054654 |
cockpituous
changed the title
jelly
reviewed
Nov 22, 2023
| podman pull quay.io/samba.org/samba-ad-server | ||
| # See https://github.com/Fmstrat/samba-domain ; docker.io/nowsci/samba-domain works fine | ||
| # but we have to build ourselves due to docker pull rate limits | ||
| git clone --depth=1 https://github.com/Fmstrat/samba-domain /var/tmp/samba-domain |
There was a problem hiding this comment.
We didn't pin it in the past, and I'd actually like to get updates. We can pin it if/when it breaks, but I wouldn't like to do that in advance.
There was a problem hiding this comment.
Alright, approved! We pin it indirectly with a refresh so we are quite flexible in that regard.
jelly
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 392d6b2 moved to quay.io/samba.org/samba-ad-server, but this has a serious and difficult bug [1] with connecting to the Global Directory.
Go back to the previous https://github.com/Fmstrat/samba-domain container. The official dockerhub image actually works very well now, but we still have to build ourselves due to the docker.io pull rate limits.
Also don't re-add the external volumes -- we are not interested in permanently keeping any Samba data.
[1] samba-in-kubernetes/samba-container#160
I built this locally, and it looks promising. Let's give it a good workout!