Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix: Update README.md #774

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Typo fix: Update README.md #774

wants to merge 3 commits into from

Conversation

Chaitanyassr
Copy link

@Chaitanyassr Chaitanyassr commented Apr 16, 2020 •
edited
Loading

fix issue #773

  • Added "the" between "be same".
  • fix Similarly
  • changed "file" to "files"

@TravisBuddy
Copy link

Hey @Chaitanyassr,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: bd01cbb0-7fae-11ea-8584-e9567e2fd09d

abhishalya
abhishalya requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@abhishalya abhishalya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve commit shortlog and the message. Otherwise chages look good

@Chaitanyassr Chaitanyassr changed the title Update README.md Typo fix: Update README.md Apr 22, 2020
@TravisBuddy
Copy link

Hey @Chaitanyassr,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f1665d90-8471-11ea-aa8b-a3fb45836a64

@abhishalya
Copy link
Member

Please squash commits into one, and rebase. Also, CI should pass this time.

@SharmaJiKaBeta
Copy link

Hey,
is this thread still open i was wondering if i could start with basics of open source working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishalya abhishalya abhishalya requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chaitanyassr @TravisBuddy @abhishalya @SharmaJiKaBeta